diff --git a/tools/tasks/helpers/questPorting/portQBData.ts b/tools/tasks/helpers/questPorting/portQBData.ts index 59dcbb3..28b7277 100644 --- a/tools/tasks/helpers/questPorting/portQBData.ts +++ b/tools/tasks/helpers/questPorting/portQBData.ts @@ -135,8 +135,8 @@ export default class PortQBData { } else { this.ref = await input({ message: - "What Commit SHA, Tag OR Branch should we compare to? (Defaults to 'main')", - default: "main", + "What Commit SHA, Tag OR Branch should we compare to? (Defaults to 'HEAD')", + default: "HEAD", }); } diff --git a/tools/tasks/helpers/questPorting/portQBModifications.ts b/tools/tasks/helpers/questPorting/portQBModifications.ts index 03de7b6..8e18173 100644 --- a/tools/tasks/helpers/questPorting/portQBModifications.ts +++ b/tools/tasks/helpers/questPorting/portQBModifications.ts @@ -209,7 +209,8 @@ function findAllParsers(modify: Modified): { function assertIsModification(change: QuestChange) { if (change.op !== "replace") throw new Error(dedent` - Runtime Exception: Addition/Removal Should Not Happen Here! Report this to the Core Devs of Nomi-CEu! + Runtime Exception: Addition/Removal Should Not Happen Here! + If this is a Proper Change, Report this to the Core Devs of Nomi-CEu! Path: ${change.path.toString()} `); } @@ -297,7 +298,11 @@ const modifyIcon = async ( modify: Modified, change: QuestChange, ) => { - assertIsModification(change); + // Tag Compounds might be removed/added + if ( + change.path.toString() !== "properties:10,betterquesting:10,icon:10,tag:10" + ) assertIsModification(change); + const oldIcon = modify.oldQuest["properties:10"]["betterquesting:10"]["icon:10"]; const newIcon = @@ -831,6 +836,7 @@ export const modificationParsers = [ logic: { type: LogicType.Simple, applyOnce: true, + formattedName: () => "Icon Modification", func: modifyIcon, }, },